Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add [Gen 9] Draft Factory #10213

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Add [Gen 9] Draft Factory #10213

wants to merge 4 commits into from

Conversation

MathyFurret
Copy link
Contributor

@MathyFurret MathyFurret commented Mar 19, 2024 •
edited
Loading

Pending final data schema

@MathyFurret
Copy link
Contributor Author

MathyFurret commented Jul 29, 2024 •
edited
Loading

I currently have written a command that accepts a URL to a CSV of team pastes. It fetches them, converts the teams to JSON and stores them in a database.

For example, typing something like /draftfactory import https://pastebin.com/t3ps7Ljr, test1 would store the following:
image

For the format to be fully functional this is what is needed:

  • Much better error checking (being admin-only is really the only barrier so far)
  • Have the team generator pull from the database to generate teams. This will be tricky as all battle code is synchronous but our current sqlite lib is all async. It should probably be more efficient than loading every single team into memory at once.
  • Make unit tests compatible
  • Anything else the Draft leaders deem necessary

@Karthik99999 Karthik99999 mentioned this pull request Nov 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KrisXV KrisXV KrisXV left review comments

@AnnikaCodes AnnikaCodes Awaiting requested review from AnnikaCodes AnnikaCodes will be requested when the pull request is marked ready for review AnnikaCodes is a code owner

@monsanto monsanto Awaiting requested review from monsanto monsanto will be requested when the pull request is marked ready for review monsanto is a code owner

@Marty-D Marty-D Awaiting requested review from Marty-D Marty-D will be requested when the pull request is marked ready for review Marty-D is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MathyFurret @KrisXV